Chris M. Hostetter created SOLR-18039:
-----------------------------------------

             Summary: knn QParser should support multiple parents.preFilter 
params
                 Key: SOLR-18039
                 URL: https://issues.apache.org/jira/browse/SOLR-18039
             Project: Solr
          Issue Type: Improvement
          Components: vector-search
            Reporter: Chris M. Hostetter


Followup to SOLR-17736...
{quote} [This...] only support a single instance of {{parents.preFilter}} - but 
the regular {{preFilter}} can be specified multiple times.
 * This feels inconsistent?
 * It should be fairly easy to change {{localParams.get(PARENTS_PRE_FILTER)}} 
to {{localParams.getParams(PARENTS_PRE_FILTER)}} and then refactor some of the 
"loop over a String[] to produce a List<Query> of filters" logic out of 
{{AbstractVectorQParserBase.getFilterQuery()}} into a helper method that could 
be used here (and then just build a BooleanQuery from that List<Query>
 * Either way: when the {{{}parents.preFilter{}}}(s) are parsed, you should 
make sure {{setIsFilter(true)}} is called on the subQuery QParser (before 
calling {{getQuery()}} - that can help other QParsers optimize what they 
return.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to