dsmiley commented on code in PR #3859:
URL: https://github.com/apache/solr/pull/3859#discussion_r2629239930
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -880,12 +880,12 @@ public static void checkDiskSpace(
req.setResponseParser(new InputStreamResponseParser("prometheus"));
var cloudClient = (CloudHttp2SolrClient) cloudManager.getSolrClient();
- var http2Client = (Http2SolrClient) cloudClient.getHttpClient();
+ var httpClient = (HttpJettySolrClient) cloudClient.getHttpClient();
- SolrResponse resp =
- http2Client.requestWithBaseUrl(parentShardLeader.getBaseUrl(),
req::process);
+ SolrResponse resp =
httpClient.requestWithBaseUrl(parentShardLeader.getBaseUrl(), req::process);
Review Comment:
I wouldn't be surprised if we deprecate the method you are calling. It's
overloaded; the other one is defined on the base client, is used somewhat
widely, and returns a NamedList. Looking at the code here, you only want a
NamedList, not SolrResponse specifically.
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -880,12 +880,12 @@ public static void checkDiskSpace(
req.setResponseParser(new InputStreamResponseParser("prometheus"));
var cloudClient = (CloudHttp2SolrClient) cloudManager.getSolrClient();
- var http2Client = (Http2SolrClient) cloudClient.getHttpClient();
+ var httpClient = (HttpJettySolrClient) cloudClient.getHttpClient();
Review Comment:
I suspect you no longer even need to cast... but whatever.
##########
changelog/unreleased/SOLR-17955-SplitShardCmd.checkDiskSpace fix.yml:
##########
@@ -0,0 +1,9 @@
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+title: OTEL metrics - SplitShardCmd.checkDiskSpace needs conversion
+type: fixed
+authors:
+ - name: Matthew Biscocho
+ - name: David Smiley
+links:
+ - name: SOLR-17955
Review Comment:
maybe reference both JIRA issues that this addresses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
