igiguere opened a new pull request, #3955:
URL: https://github.com/apache/solr/pull/3955

   https://issues.apache.org/jira/browse/SOLR-17136
   
   # Description
   
   Replacing uses of GenericSolrRequest to call "/admin/info/system" by a 
SystemInfoRequest implementation in the CLI tool.
   
   # Solution
   
   Adding SystemInfoRequest implementation.  SystemInfoRequest can toggle 
between the V1 and V2 APIs.  The V2 API was already available at 
/api/node/system.  
   
   Adding API model class org.apache.solr.api.model.SystemInfoResponse to 
represent the system info response, and SorlJ response class 
org.apache.solr.client.solrj.response.SystemInfoResponse to map the NamedList 
response to the API model.
   
   # Tests
   
   Unit tests pass.
   
   Functional tests using the CLI tool, where most of the changes occurred.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [*] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [*] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [*] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [*] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [*] I have added a [changelog 
entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my 
change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to