epugh commented on code in PR #3706: URL: https://github.com/apache/solr/pull/3706#discussion_r2623033894
########## solr/packaging/test/test_docker_solrcloud.bats: ########## @@ -0,0 +1,158 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +load bats_helper + +# Environment variables for Docker images +SOLR_BEGIN_IMAGE="${SOLR_BEGIN_IMAGE:-apache/solr-nightly:9.10.0-SNAPSHOT-slim}" +SOLR_END_IMAGE="${SOLR_END_IMAGE:-apache/solr-nightly:10.0.0-SNAPSHOT-slim}" + +setup() { + common_clean_setup + + # Pre-checks + docker version || skip "Docker is not available" + docker pull "$SOLR_BEGIN_IMAGE" || skip "Docker image $SOLR_BEGIN_IMAGE is not available" + docker pull "$SOLR_END_IMAGE" || skip "Docker image $SOLR_END_IMAGE is not available" + + # Record test start time for scoping logs on failure + TEST_STARTED_AT_ISO=$(date -Iseconds) + export TEST_STARTED_AT_ISO + + # Persist artifacts under Gradle’s test-output (fallback to Bats temp dir) Review Comment: do we need this? AI likes ot have fallbacks and null checks, but it makes things more verbose. Let's just pick one or the other. I actually like having it under `test-output` as i find the bats temp dir hard to find when I need to debug ;-). maybe we should put it under `test-output`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
