janhoy commented on PR #3938:
URL: https://github.com/apache/solr/pull/3938#issuecomment-3652462136

   > If the root cause is what it says it is (seems very plausible to me!), 
then why isn't this PR nothing more than simply moving this line _with it's 
preceding comments:_
   > 
   > > ```
   > > System.setProperty(SYS_PROP_CACHE_TIMEOUT_SECONDS, "" + 
Integer.MAX_VALUE);
   > > ```
   > 
   > To the beginning of setupCluster? I would approve that, but the change 
here seems needlessly more involved and I'm unsure if it's actually as 
comprehensive as what I suggest. What I suggest covers _all_ clients, including 
the several ones created at the start.
   
   Well spotted and for zooming out from the context of the failing test. This 
solution is more elegant. I added collection, and ran tests.iters many times, 
as well as the whole suite with tests.dups (some tests don't support 
tests.iters), all looks goodl


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to