[
https://issues.apache.org/jira/browse/SOLR-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18044575#comment-18044575
]
Jan Høydahl commented on SOLR-17928:
------------------------------------
[~ichattopadhyaya] this trips on an errorprone rule during precommit. Running
precommit locally will normally not trigger errorprone, but in GitHub it does:
{code:java}
> Task :solr:core:compileJava
/home/runner/work/solr/solr/solr/core/src/java/org/apache/solr/search/vector/SolrKnnByteVectorQuery.java:53:
warning: [EqualsGetClass] Prefer instanceof to getClass when implementing
Object#equals.
public boolean equals(Object obj) {
^
(see https://errorprone.info/bugpattern/EqualsGetClass)
Did you mean 'if (!(obj instanceof SolrKnnByteVectorQuery)) return false;'?
{code}
> Add efSearch parameter to knn query
> -----------------------------------
>
> Key: SOLR-17928
> URL: https://issues.apache.org/jira/browse/SOLR-17928
> Project: Solr
> Issue Type: Improvement
> Components: vector-search
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Right now, only topK can be requested. efSearch is a standard overfetch
> parameter.
> Proposing that we add it for better recall accuracy.
> (FYI, Elasticsearch calls it num_candidates. Commonly referred to as
> efSearch, similar to efConstruction that we call beamWidth)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
