[
https://issues.apache.org/jira/browse/SOLR-17995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18043756#comment-18043756
]
Sanjay Kumar Yadav commented on SOLR-17995:
-------------------------------------------
[~dsmiley] i am assuming there are two parts to it - 1. address the first part
of the improvement - "{{{}SolrStream{}}} takes a "baseUrl" but in practice,
this is a URL that includes a core/collection. It even internally concatenates
a "core" field (which cannot be set by user code) to baseUrl and then looks up
a client with SolrClientCache. Ideally, these aspects would be well separated.
A collection/core should be a required param, and it should be passed to the
request method, which is overloaded to take it. This way the SolrClientCache
isn't polluted with core/collection specific clients."
and #2 Perhaps separate issue but it would be lovely to instantiate a
SolrStream with an existing SolrClient, thus without bothering with
SolrClientCache
does it need to be both or later or first ?
> SolrStream API should separate baseUrl from core/collection
> -----------------------------------------------------------
>
> Key: SOLR-17995
> URL: https://issues.apache.org/jira/browse/SOLR-17995
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ, streaming expressions
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
>
> {{SolrStream}} takes a "baseUrl" but in practice, this is a URL that includes
> a core/collection. It even internally concatenates a "core" field (which
> cannot be set by user code) to baseUrl and then looks up a client with
> SolrClientCache. Ideally, these aspects would be well separated. A
> collection/core should be a required param, and it should be passed to the
> request method, which is overloaded to take it. This way the SolrClientCache
> isn't polluted with core/collection specific clients.
> Perhaps separate issue but it would be lovely to instantiate a SolrStream
> with an existing SolrClient, thus without bothering with SolrClientCache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
