dsmiley commented on PR #3913: URL: https://github.com/apache/solr/pull/3913#issuecomment-3621179318
It's too late, but in retrospect the changes should have been done in a way that preserves history. For example BasicDistributedZkTest today shows you as essentially the complete author, without seeing why certain lines are the way they are. It's difficult to retrieve the true history, which technically isn't lost. Next time (and I'd be very willing to help), the BasicDistributedZkTest classes could have been removed as one commit, then rename the "Abstract" variants to replace them in another commit, then bring forward the changes in a 3rd commit. This could have been done on a branch that was merged. There's a way to kind of repair history locally but not published. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
