gerlowskija opened a new pull request, #3925: URL: https://github.com/apache/solr/pull/3925
https://issues.apache.org/jira/browse/SOLR-18014 # Description Our file store implementation has an internal API used to fetch filestore files from other nodes in the cluster. A specific node in the cluster can be specified as the source to pull from using the "getFrom" query parameter. But nothing actually validates the provided "getFrom" value or ensures it's another node in the cluster. # Solution This PR checks the value of "getFrom" when provided and ensures it is a known live node. # Tests Additional scenario added to TestDistribFileStore to exercise the error message. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
