[
https://issues.apache.org/jira/browse/SOLR-17461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042966#comment-18042966
]
Sanjay Kumar Yadav commented on SOLR-17461:
-------------------------------------------
[~dsmiley] please help me understand with basic questions -
solrJ ( no dependency of caffeine )
ClusterState part of solrJ module where it has no dependency caffeine library.
Sorl core ( has dependency for caffeine )
CoreContainer --> set a string interner for ClusterState who is not aware
about the state of availability
effectively we are saying - Solr-core is required for SolrJ , Right ?
i see there could be two approached -
1. add string interner code in core which ClusterState can call during static
initialization
2. move the interner core into solrJ and use it for initialization?
let me know if there are more alternative not in mine top two list
> (cleanup) Move ClusterState string "Interner" json parser to Utils
> ------------------------------------------------------------------
>
> Key: SOLR-17461
> URL: https://issues.apache.org/jira/browse/SOLR-17461
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: Noble Paul
> Priority: Minor
> Labels: newdev
>
> ClusterState.setStrInternerParser and its functionality is potentially of
> general utility and it's also a bit distracting in ClusterState. I also
> don't like CoreContainer being involved in initializing it (CoreContainer is
> doing too much!). It's doing it because ClusterState is in SolrJ without
> Caffeine being on the classpath. Instead, imagine a class in solr-core that
> implements this Function. Utils could then self-initialize via reflection
> detecting if that class is available, otherwise gracefully resorting to the
> non-intern mechanism. No touching CoreContainer which is way too busy doing
> many things.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
