dsmiley commented on code in PR #3923:
URL: https://github.com/apache/solr/pull/3923#discussion_r2591079271
##########
solr/core/src/java/org/apache/solr/schema/LatLonPointSpatialField.java:
##########
@@ -264,15 +264,13 @@ public int hashCode() {
@Override
public DoubleValues getValues(LeafReaderContext ctx, DoubleValues
scores) throws IOException {
- return new DoubleValues() {
-
- @SuppressWarnings("unchecked")
- final FieldComparator<Double> comparator =
- (FieldComparator<Double>) getSortField(false).getComparator(1,
Pruning.NONE);
-
- final LeafFieldComparator leafComparator =
comparator.getLeafComparator(ctx);
- final double mult = multiplier; // so it's a local field
+ @SuppressWarnings("unchecked")
Review Comment:
I intentionally had the code as fields of the inner class so that references
to them in advanceExact would be local, without an indirection. Can you move
leafComparator & mult back please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
