[ 
https://issues.apache.org/jira/browse/SOLR-16689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042193#comment-18042193
 ] 

Jason Gerlowski commented on SOLR-16689:
----------------------------------------

+1 [~liangkaiwen] - have you tried removing that bit of code to see how it 
impacts the tests?  That'd be the first "sniff test" IMO to see whether this is 
truly needed or not.

> Inefficiencies in replication process
> -------------------------------------
>
>                 Key: SOLR-16689
>                 URL: https://issues.apache.org/jira/browse/SOLR-16689
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 9.1.1
>            Reporter: Justin Sweeney
>            Assignee: Justin Sweeney
>            Priority: Major
>             Fix For: 9.2
>
>
> There are a couple of inefficiencies with replication that can cause 
> increased CPU usage unnecessarily due to replicas being added:
>  # The 
> [RecoveryStrategy.replicate()|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java#L219]
>  method makes a call to commit to on the leader. This happens whenever a 
> replica is reloaded. For PULL replicas in particular this isn't necessary 
> since we can just pull down whatever the latest data is and rely on other 
> mechanisms to be consistently committing the leader. (As an aside, it seems 
> like forcing a commit on the leader might never be necessary, but for this 
> I've limited it to focusing on PULL replicas).
>  # In a case where the leader has no data yet (index version is 0), then a 
> non-leader replica will consistently delete and recreate its core due to this 
> case in IndexFetcher: 
> [https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/handler/IndexFetcher.java#L549.]
>  This can cause unnecessary CPU usage until the leader has data indexed to it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to