janhoy commented on PR #3908: URL: https://github.com/apache/solr/pull/3908#issuecomment-3601624226
> > Starting with 10, can we at least have specifically the metrics be merely a single node that's proxied? IMO that's at least the right direction. And hopefully it'd spare the rather complex metrics processing here, and buffering. > > Not sure I understand this comment. But I **think** you may mean that the UI instead of requesting metrics from all nodes in one go with the `nodes=X,Y,Z` param, it could fire three requests, one with `nodes=X`, one `nodes=Y` and noe `nodes=Z`? Definitely a possibility. I implemented this. So now backend does no merging, but supports a single `&node=<nodeName>` param that will fetch metrics for that node. The frontend now loops over selected (visible) nodes in the cloud screen, and fetches metrics for each in parallel (from the same backend, but with different `node` param). This removes lots of code from backend, no more inserting "node" label in prom text, no more merging all lines in one response, and smaller tmp String object being cached. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
