pratsgit commented on PR #3750: URL: https://github.com/apache/solr/pull/3750#issuecomment-3594909885
Hi all, I’ve pushed a set of updates based on the feedback so far: 1. Switched the integration tests to use Testcontainers with Azurite (no hard-coded ports / external prereqs) and disabled the Security Manager for this module’s tests, following the pattern used in the extraction module. 2. Addressed HTTP client concerns by using azure-core-http-okhttp and keeping those deps in test scope only, plus explicit test deps. 3. Cleaned up and significantly shortened the README and docs 4. Did additional cleanup to align naming, structure, and configuration patterns with those of the existing repository plugins. Please let me know if anything else should be adjusted that would help move the review forward. Happy to make further changes. Thanks again for the thoughtful review and guidance so far! — Prateek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
