[
https://issues.apache.org/jira/browse/SOLR-17962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041713#comment-18041713
]
ASF subversion and git services commented on SOLR-17962:
--------------------------------------------------------
Commit ab330d40d600dd1672403ff230c28e76101b12ca in solr's branch
refs/heads/branch_10x from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=ab330d40d60 ]
SOLR-17962: Move tests relating to Apache HttpClient (#3888)
to test-framework, org.apache.solr.client.solrj.apache
And copied/ported some individual tests that were not yet present in the
surviving clones of these test suites.
Move SolrJMetricTestUtils to test-framework.
@Ignore Apache HttpClient tests relying on SolrJ fixtures/resources since they
are not available in the test framework (the new home), and these tests will be
removed soon anyway.
> Don't include Apache HttpClient JARs in Solr (server)
> -----------------------------------------------------
>
> Key: SOLR-17962
> URL: https://issues.apache.org/jira/browse/SOLR-17962
> Project: Solr
> Issue Type: Sub-task
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 10.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> At this point of the migration, we shouldn't need to ship Apache HttpClient
> JARs in Solr. It's getting there because SolrJ still has SolrClient
> implementations depending on it. There's too much work remaining to actually
> completely remove them at this time, due to their extensive uses in tests,
> still.
> Possibilities; not all mutually exclusive:
> (A) Mark those dependencies as optional somehow (Maven POM), hopefully also
> affecting our build. Thus solr-core won't depend on it transitively.
> (B) exclude the transitives where solr-core depends on SolrJ. Simple.
> (C) move them to a new module solrj-apache-httpclient but that doesn't seem
> like a good idea as they are deprecated.
> *(D) move them to solr-test-framework (CHOSEN)*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
