[ 
https://issues.apache.org/jira/browse/SOLR-18005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041657#comment-18041657
 ] 

ASF subversion and git services commented on SOLR-18005:
--------------------------------------------------------

Commit 2c55000296bb04e12e2bfae83eca7e5f11caba0e in solr's branch 
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=2c55000296b ]

SOLR-18005 SolrJ: consolidate Jetty-using classes to a jetty package (#3901)

Classes using Jetty HttpClient have been moved to a new package 
`org.apache.solr.solrj.jetty`.
The following classes were renamed with some refactorings: `Http2SolrClient` to 
`HttpJettySolrClient`, `ConcurrentUpdateHttp2SolrClient` to 
`ConcurrentUpdateJettySolrClient`, `LBHttp2SolrClient` to `LBJettySolrClient`.
`CloudHttp2SolrClient.Builder` has moved to `CloudSolrClient`; users should 
generally have no need to refer to `CloudHttp2SolrClient` or any class/member 
with "http2" in it.
CloudSolrClient.Builder will check if Jetty `HttpClient` is available and use 
that, otherwise fallback on a JDK based `HttpClient`.
`CloudJettySolrClient` is new, proving an explicit option.

* streaming: SolrClientCache: reduce Jetty dependency.  Make more extensible.
* PreemptiveBasicAuthClientBuilderFactory: reference in new package
* the SolrJ "embedded" package is now gone; only had a Jetty-specific SSLConfig 
that moved.

* restore accidental partial revert of props:
** solr.http.cookies.enabled,
** solr.keystore.reload.enabled,
** solr.jetty.ssl.context.reload.scan.interval.secs

> Rename & move jetty based SolrClient code to its own package
> ------------------------------------------------------------
>
>                 Key: SOLR-18005
>                 URL: https://issues.apache.org/jira/browse/SOLR-18005
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 10.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> (split off from SOLR-17161)
> SolrJ code depending on Jetty ought to be in a separate Java package.  
> Propose: {{org.apache.solr.client.solrj.jetty}}.  Classes in there should 
> generally have Jetty in the name, like ConcurrentUpdateJettySolrClient, 
> LBJettySolrClient, CloudJettySolrClient, HttpJettySolrClient.  This means not 
> just renames but sometimes splitting Jetty-ness out of other classes that 
> otherwise barely have any such dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to