epugh opened a new pull request, #3905: URL: https://github.com/apache/solr/pull/3905
https://issues.apache.org/jira/browse/SOLR-15349 # Description According to the JIRA, solrcore.properties has been deprecated, though in looking closer, it appears that mentioning has been hidden/removed, but the code is still there. # Solution I have removed the solrcore.properties support from CoreDescriptor. In the process, I see that we still support the concept of a custom properties file for a core, and loading that. Therefore I updated the unit test to exercise that code path. I am thinking that we should rename `TestSolrCoreProperties.java` to `TestCustomCoreProperties.java` as we no longer have a `solrcore.properties` concept. Now, if the whole properties for a Core concept is no longer relevant, I'd be happy to remove the whole thing! I will backport to 9x a deprecation on `CoreDescriptor`. If 10 releases before this gets sorted, then I guess this will be a 11x feature. # Tests Updated unit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
