epugh commented on code in PR #3902:
URL: https://github.com/apache/solr/pull/3902#discussion_r2573015162
##########
solr/core/src/test/org/apache/solr/response/TestRawResponseWriter.java:
##########
@@ -162,8 +173,33 @@ public void testStructuredDataViaBaseWriters() throws
IOException {
assertEquals("test", out.getVal(0));
assertEquals("foo", out.getName(1));
assertEquals("bar", out.getVal(1));
- }
+ // cbor
+
+ byte[] cborBytes = serializeToCbor(json.getBytes());
+ assertEquals(25, cborBytes.length);
+ LongAdder docsSz = new LongAdder();
Review Comment:
nit picky, but the variable name `docsSz` isn't helping me read the code
quickly and understand it...
##########
solr/core/src/test/org/apache/solr/response/TestRawResponseWriter.java:
##########
@@ -51,9 +60,10 @@ public static void setupCoreAndWriters() throws Exception {
writerXmlBase = newRawResponseWriter("xml");
writerJsonBase = newRawResponseWriter("json");
writerBinBase = newRawResponseWriter("javabin");
+ writeCborBase = newRawResponseWriter("cbor");
allWriters =
- new RawResponseWriter[] {writerXmlBase, writerJsonBase, writerBinBase,
writerNoBase};
+ new RawResponseWriter[] {writerXmlBase, writerJsonBase,
writerBinBase,writeCborBase, writerNoBase};
Review Comment:
run the `tidy` command to get code formatting to our standard.
##########
solr/core/src/test/org/apache/solr/response/TestRawResponseWriter.java:
##########
@@ -62,7 +72,7 @@ public static void cleanupWriters() {
writerJsonBase = null;
writerBinBase = null;
writerNoBase = null;
-
+ writeCborBase = null;
Review Comment:
maybe to be consistent, `writerCborBase`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
