rahulgoswami commented on PR #3883: URL: https://github.com/apache/solr/pull/3883#issuecomment-3579561700
> If no merge is found, perhaps it should seek a possible merge of the previous major version? Or just leave that as a future improvement possibility, I suppose. Including previous major version could mean an older version segment could potentially merge with a current version segment. Which means when we upgrade to the next Lucene version, the index may not open, since the check in Lucene now checks for SegmentCommitInfo.minVersion (oldest of the different versions of segments merging to form a given segment) and that may now fall below the N-1 version compatibility. Having said that, I have kept the allowSegmentForMerge() method 'protected' to allow for a different predicate if a class wants to extend this. > I could see this being contributed to Lucene. Makes sense. I'll try asking on the dev list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
