dsmiley commented on code in PR #3888:
URL: https://github.com/apache/solr/pull/3888#discussion_r2558475604
##########
solr/test-framework/src/java/org/apache/solr/util/SolrJMetricTestUtils.java:
##########
Review Comment:
@mlbiscoc : moving this to test-framework, and `util` package so it can be
used more widely
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClientTest.java:
##########
@@ -33,22 +49,134 @@
import org.eclipse.jetty.ee10.servlet.ServletHolder;
import org.junit.BeforeClass;
import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class ConcurrentUpdateHttp2SolrClientTest extends SolrJettyTestBase {
+ private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
Review Comment:
copied a couple inner classes referenced referenced from a test based on
Apache HttpClient
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClientTest.java:
##########
@@ -263,4 +385,35 @@ public OutcomeCountingConcurrentUpdateSolrClient build() {
}
}
}
+
+ /**
+ * Test that connection timeout information is passed to the HttpSolrClient
that handles non add
+ * operations.
+ */
+ @Test(timeout = 10000)
+ public void testSocketTimeoutOnCommit() throws IOException,
SolrServerException {
Review Comment:
ported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
