dsmiley commented on code in PR #3708:
URL: https://github.com/apache/solr/pull/3708#discussion_r2553234155
##########
solr/core/src/test/org/apache/solr/TestCrossCoreJoin.java:
##########
@@ -245,6 +218,14 @@ public String query(SolrCore core, SolrQueryRequest req)
throws Exception {
@AfterClass
public static void nukeAll() {
+ if (fromServer != null) {
Review Comment:
see IOUtils.closeQuietly which is nice.
Also, it's a good practice to null out a static field. Little point if
non-static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
