dsmiley commented on code in PR #3884: URL: https://github.com/apache/solr/pull/3884#discussion_r2547859372
########## solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java: ########## Review Comment: I strongly feel that at some point (not necessarily this PR), we're going to want to offer control on how these are created so it can be customized to someone's liking. For example even for compatibility -- this change now forces the OTEL version to be at least this version to do something minor. I could see someone wanting to use their OTEL version for whatever reason and create the SdkMeterProvider themselves. I'm not sure yet how we would enable that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
