dsmiley opened a new pull request, #3878: URL: https://github.com/apache/solr/pull/3878
Just a minor improvement to simplify close handling. What prompted this was a mock test in another change that yielded a null lbSolrClient from a mocked method (normally impossible)... and I wanted the close() method to be graceful, even in the face of that, which would normally never happen. I ended up being pretty happy with the results. Seeing closeMyClientIfNeeded made me frown; I wanted that gone in place of close(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
