[
https://issues.apache.org/jira/browse/SOLR-17935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18038445#comment-18038445
]
David Smiley commented on SOLR-17935:
-------------------------------------
I got curious too and found out why fairly quickly thanks to our awesome test
infrastructure -- ObjectReleaseTracker. All I did was track & release the
inputstream in InputStreamResponseParser, knowing this test _should_ (in
theory), only get and consume the stream via this class. Low and behold,
addRandomDocument (and some other methods) uses one of these clients with a
customized response parser to add documents. I have a change to the PR to
modify these methods to use a normal client --
{{cluster.getSolrClient(collection)}} -- that which hasn't been customized with
this special parser. Ideally this test wouldn't use InputStreamParser for what
it's doing. For the Xml side -- shouldn't be needed -- can just use
XMLResponseParser. It could use JsonMapResponseParser for the JSON side.
> Remove NoOpResponseParser
> -------------------------
>
> Key: SOLR-17935
> URL: https://issues.apache.org/jira/browse/SOLR-17935
> Project: Solr
> Issue Type: Sub-task
> Reporter: Eric Pugh
> Assignee: Eric Pugh
> Priority: Minor
> Labels: pull-request-available
> Fix For: 10.0
>
> Attachments: relocate_query_parser.patch
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The NoOpResponseParser has been deprecated in favour of the
> InputStreamResponseParser
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
