janhoy commented on PR #1951: URL: https://github.com/apache/solr/pull/1951#issuecomment-3515344926
Yea, consistency is good. When you say port scanning, what really goes on isn’t scanning all 64k ports but rather listing all processes, filtering on Java/solr processes, parsing -Djetty.port from the args. This was moved to the Java class SolrProcesses. Sometimes we can add too much magic. Not sure if it’s right to not require a `-p` if we happen to find Solr running on some none standard port, just because it’s the only Solr process currently running on the host. That’s not deterministic if there used to be two Solrs and one is temporarily down. I see lots of pr comments, not sure if I’m able to put much time in a thorough review.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
