dsmiley commented on code in PR #3835:
URL: https://github.com/apache/solr/pull/3835#discussion_r2512337560
##########
solr/core/src/java/org/apache/solr/handler/admin/MetricsHandler.java:
##########
@@ -122,6 +122,11 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
+ format);
}
+ if (!isEnabled()) {
+ rsp.add("metrics", MetricSnapshots.builder().build());
Review Comment:
No, I mean write to the client for a user to see. The output would still be
valid exposition, I assume
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
