[ 
https://issues.apache.org/jira/browse/SOLR-17810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18035493#comment-18035493
 ] 

David Smiley commented on SOLR-17810:
-------------------------------------

Ah; that rename is in a pending PR.  Assuming you have an up-to-date checkout, 
then I refer to \{{org.apache.solr.client.solrj.apache.HttpSolrClient}} which 
is about to be renamed.

A possible trick when hunting for tests is to make a local change to break 
something that would cause a test you are interested in (yet can't find) to 
break.  So see where the header is read, and throw an exception if found.  Then 
run all tests.

> RateLimiting doesn't work for non-Apache Http SolrClients
> ---------------------------------------------------------
>
>                 Key: SOLR-17810
>                 URL: https://issues.apache.org/jira/browse/SOLR-17810
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev
>
> Solr's rate limiting SOLR-13528 needs to know the request type to do its job. 
>  This is passed as a HTTP header, but at present only the deprecated 
> HttpSolrClient is doing this.  The others should too!  See this comment Just 
> now. 
> All we have to do is ensure that the Jetty & JDK based HTTP SolrClients pass 
> on an HTTP header, just like the Apache one does.  Hopefully this can happen 
> in their base class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to