[
https://issues.apache.org/jira/browse/SOLR-17562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18035141#comment-18035141
]
David Smiley commented on SOLR-17562:
-------------------------------------
{quote}To be explicit: you're proposing that InputStreamResponse should be
moved to "org.apache.solr.client.solrj.response"?
{quote}
yes. The bigger picture is being conservative/mindful of the contents of the
package org.apache.solr.client.solrj. Anything in there that has an obvious
sub-package to go to, should go to that sub-package.
We'd be moving a class; not removing it. I don't think a deprecation is
suitable – it's not actionable for a user. It's reasonable to expect users to
potentially need to change some things for a major release. This one would be
quite trivial!
RE 9.x releases; see this thread of mine:
[https://lists.apache.org/thread/kwksgomjrj0wh2ygc4snfvm9j2pb1knx] – happy to
discuss that on the list if desired.
> Unify v2 API streaming support
> ------------------------------
>
> Key: SOLR-17562
> URL: https://issues.apache.org/jira/browse/SOLR-17562
> Project: Solr
> Issue Type: Improvement
> Components: v2 API
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Labels: pull-request-available
> Fix For: 9.9, 10.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Several v2 APIs return raw files or streams of data, including:
> {{ZooKeeperReadAPI}}, {{NodeFileStore}}, and {{CoreReplication.fetchFile}}.
> But the APIs vary slightly in how they support this: ZooKeeperReadAPI uses
> the deprecated "ContentStream" with "RawResponseWriter", NodeFileStore
> directly attaches a "SolrCore.RawWriter" to the underlying SolrQueryResponse,
> and CoreReplication follows the JAX-RS best practice of using the
> "StreamingOutput" interface.
> This ticket aims to align all of these approaches and document our approach
> in {{dev-docs/apis.adoc}} or a similar file.
> The preferred approach ([see discussion
> here|https://github.com/apache/solr/pull/2734]) at the time of writing is to
> use StreamingOutput. If this doesn't change, this ticket will need to:
> * modify our Java codegen template and related code to support this new
> response type. (Java codegen currently requires that all responses subclass
> SolrJerseyResponse)
> * remove the "x-omitFromCodegen" tag from any APIs using StreamingOutput (see
> ReplicationApis.fetchFile for an example)
> * Switch other raw-file/streaming APIs over to using StreamingOutput.
> Validate v1 and v2 responses.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
