malliaridis commented on PR #3810:
URL: https://github.com/apache/solr/pull/3810#issuecomment-3469093120

   I have added a solr startup for the zk tests and fixed a a false-positive 
issue in two of the tests.
   
   I spent about 6 hours to make these changes work, so my experience was not 
ideal.
   
   The powershell tests are also not optimal and would require some further 
optimizations in the long run. Any std.err log, including warnings, are 
recognized as errors by the powershell, leading to some outputs to include a 
report of a `NativeCommandError` which matched the error condition and failed 
the test.
   
   Because I am also short in time, I thought I share my discoveries for the 
next person working on this. In my opinion though we could merge it as is. I 
got passing tests on Windows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to