epugh commented on code in PR #3814:
URL: https://github.com/apache/solr/pull/3814#discussion_r2464226297
##########
solr/bin/solr:
##########
@@ -956,8 +964,8 @@ if [ -n "${SOLR_PORT_ADVERTISE:-}" ]; then
SCRIPT_SOLR_OPTS+=("-Dsolr.port.advertise=$SOLR_PORT_ADVERTISE")
fi
-if [ -n "${SOLR_JETTY_HOST:-}" ]; then
- SCRIPT_SOLR_OPTS+=("-Dsolr.jetty.host=$SOLR_JETTY_HOST")
+if [ -n "${SOLR_HOST_BIND:-}" ]; then
Review Comment:
if we look up `solr.host.bind` in java code with our envutils, then maybe we
don't need to these lines, because the environment variable gets mapped to
system property for us...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
