hossman commented on PR #3809:
URL: https://github.com/apache/solr/pull/3809#issuecomment-3445255521
i don't know a lot about what kinds of naming conventions github users use
when naming branches but i wonder if -- instead of requiring the
`(PR-|GH-|GITHUB-|#)` prefix in the branch name to mean "subsequent digits are
a github PR#" -- it might make sense to do something like this...
```
def githubMatcher = gitBranch =~ /(PR-|GH-|GITHUB-|#)(\d+)/
def githubRef = (githubMatcher && ! jiraMatcher) ?
githubMatcher.group(2) : ""
def githubLink = (githubMatcher && ! jiraMatcher) ? "issues:\n -
${githubRef}" : ""
```
...ie:
* if we've already determined the branch name has a `SOLR-XXX` jira
component, then don't bother checking for a github PR# component (at all)
* if it does _not_ have a `SOLR-XXX` jira component, then any number in the
branch name _might_ be a github PR#
would that make more sense?
Is anyone out there naming branches `SOLR-1235-fix-stuff-in-PR-678` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
