alessandrobenedetti commented on code in PR #3789:
URL: https://github.com/apache/solr/pull/3789#discussion_r2450953510
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -86,13 +86,13 @@ public class DenseVectorField extends FloatPointField {
* This parameter is coupled with the hnsw algorithm. Controls how many of
the nearest neighbor
* candidates are connected to the new node. See {@link HnswGraph} for more
details.
*/
- private int hnswMaxConn;
+ private int m;
Review Comment:
m -> hnswM
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -86,13 +86,13 @@ public class DenseVectorField extends FloatPointField {
* This parameter is coupled with the hnsw algorithm. Controls how many of
the nearest neighbor
* candidates are connected to the new node. See {@link HnswGraph} for more
details.
*/
- private int hnswMaxConn;
+ private int m;
/**
* This parameter is coupled with the hnsw algorithm. The number of
candidate neighbors to track
* while searching the graph for each newly inserted node. See {@link
HnswGraph} for details.
*/
- private int hnswBeamWidth;
+ private int efConstruction;
Review Comment:
efConstruction -> hnswEfConstruction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
