dsmiley commented on code in PR #3044: URL: https://github.com/apache/solr/pull/3044#discussion_r2446118955
########## changelog/logchange-config.yml: ########## @@ -0,0 +1,90 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# More info about configuration you can find https://github.com/logchange/logchange#configuration +changelog: + heading: Some information that will be display in the top of CHANGELOG.md + unreleasedVersionDir: unreleased + # You can define custom entry types, which overriders default ones + # [added/changed/deprecated/removed/fixed/security/dependency_update/other] + # Remember to adjust labels below, to match new entry types f.e. add: New features + # entryTypes: # you can define custom entry types + # - key: add + # order: 1 Review Comment: Overall I like! I'm good with removing Optimized -- it's then a part of Improvements. Lucene has lots of those but not so much Solr. We don't have a JIRA type for that either. Can we have the mapping be more direct/obvious like use the enum "improvement" and "feature" etc? Shorted "dependency_update" to simply "dependency"? Can use present tense in the num. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
