dsmiley commented on code in PR #3792:
URL: https://github.com/apache/solr/pull/3792#discussion_r2442756478
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java:
##########
@@ -32,7 +32,6 @@
import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.client.solrj.SolrRequest;
import org.apache.solr.client.solrj.SolrServerException;
-import org.apache.solr.client.solrj.impl.ConcurrentUpdateSolrClient.Update;
Review Comment:
Don't want to use that internal POJO, so I created a similar record, copying
the same javadoc line as well.
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2306,12 +2306,12 @@ private ZkCoreNodeProps waitForLeaderToSeeDownState(
}
// short timeouts, we may be in a storm and this is just best effort,
and maybe we should be
- // the
- // leader now
+ // the leader now
+ // TODO .withHttpClient(getCoreContainer().getDefaultHttpSolrClient())
Review Comment:
Preferable; however that means accepting its connection timeout. Heck;
wouldn't need to create a new Http2SolrClient either; just use the default
client. Personally I'd prefer that but... :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
