epugh commented on code in PR #3710: URL: https://github.com/apache/solr/pull/3710#discussion_r2403535900
########## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/utils/Helpers.java: ########## Review Comment: so it turns out we do a lot of looking at results. I tried out a JsonMapResponseParser, but dealing with those werid nested NamedList response was a total pain... Since Prometheus is going away, and this is a 10x only change anyway, I'm inclined to either just leave me current approach, OR wait till Otel lands so I can avoid trying to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
