mlbiscoc commented on code in PR #3682:
URL: https://github.com/apache/solr/pull/3682#discussion_r2402347452
##########
solr/solr-ref-guide/modules/deployment-guide/pages/metrics-reporting.adoc:
##########
@@ -684,18 +684,18 @@ The following merge metrics are collected:
* 'solr_indexwriter_merge_time_milliseconds' - timer for total duration of
merge operations
The following metrics, in addition to the above labels for "minor"/"major"
`merge_type` also have a label for `merge_state`.
-This label can have a value of either "started" or "finished" indicating when
the value was reported ("started" when a merge
-is being prepared and "finished" when a merge is concluded).
+This label can have a value of "started", "finished", or "failed" indicating
when the value was reported ("started" when a merge
+is being prepared, "finished" when a merge is successfully concluded,
otherwise "failed").
Review Comment:
What if we record so that if the metic has `finished`, it has an additional
attribute `result` that is success or failure? Like so:
```
solr_indexwriter_merges{merge_state=started} 10.0
solr_indexwriter_merges{merge_state=completed, result=success} 7.0
solr_indexwriter_merges{merge_state=completed, result=failed} 3.0
```
> label value should be "succeeded" so that it's clear it's only success
I'm fine with this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
