Copilot commented on code in PR #3742:
URL: https://github.com/apache/solr/pull/3742#discussion_r2411237797
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##########
@@ -256,47 +257,58 @@ public void testAliasHandling() throws Exception {
@Test
@LogLevel("org.apache.solr.servlet.HttpSolrCall=DEBUG")
public void testHttpCspPerf() throws Exception {
+ // This ensures CH2SC is caching cluster status by counting the number of
logged calls to the
+ // admin endpoint. Too many calls to CLUSTERSTATUS might mean insufficient
caching and
+ // peformance regressions!
Review Comment:
Corrected spelling of 'peformance' to 'performance'.
```suggestion
// performance regressions!
```
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ClusterStateProviderTest.java:
##########
@@ -84,7 +86,12 @@ public static void setupCluster() throws Exception {
.resolve("conf"))
.configure();
cluster.waitForAllNodes(30);
- System.setProperty("solr.solrj.cache.timeout.sec", "1");
+ System.setProperty(SYS_PROP_CACHE_TIMEOUT_SECONDS, "1");
+ }
+
+ @AfterClass
+ public static void clearSystemPrperty() {
Review Comment:
Corrected spelling of 'Prperty' to 'Property' in method name.
```suggestion
public static void clearSystemProperty() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
