sandbergja opened a new pull request, #3744: URL: https://github.com/apache/solr/pull/3744
https://issues.apache.org/jira/browse/SOLR-17936 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description In the new ui, add a focus indicator around the sidebar entry that has focus. Here is a demonstration of me using Tab and Shift-Tab to navigate between the various items, and Enter to select the item I want:  # Solution Rather than using `Tab`, which does not have colors for our various states, we use `Button`, which has all colors except for the Selected state. Material 3's new "Expressive" version also provides an experiment `ToggleButton` component, but our version of the Material 3 dependency is not new enough to be able to use it (and if I understand correctly, we can't use the very newest Material 3 release, since Compose Multiplatform does not yet support it). Many thanks to @malliaridis for the guidance getting started, and for suggesting that we try a component other than `Tab`. # Tests I tested this manually in both light mode and dark mode, on both desktop and web versions of the new admin UI. I used `Tab` and `Shift+Tab` to navigate between the items in the side navigation and confirmed that the item I navigated to was always clearly marked. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
