cpoerschke commented on code in PR #3705:
URL: https://github.com/apache/solr/pull/3705#discussion_r2382911378
##########
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##########
@@ -88,6 +94,17 @@ public EarlyTerminationParams getEarlyTerminationParams() {
return new EarlyTerminationParams(enabled, saturationThreshold, patience);
}
+ protected Query getSeedQuery() throws SolrException, SyntaxError {
+ String seed = localParams.get(SEED);
+ if (seed == null) return null;
+ if (seed.isBlank()) {
+ log.warn("Seed query is blank, defaulting to null");
+ return null;
Review Comment:
minor/subjective: perhaps `throw new SolrException` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
