janhoy commented on code in PR #2391: URL: https://github.com/apache/solr/pull/2391#discussion_r2435581422
########## solr/core/src/test/org/apache/solr/cloud/TestEmbeddedZkQuorum.java: ########## Review Comment: There used to be such a test in the first phase, but it kept failing, so it was removed 😂🤣 Good point though. With this foundation it should be possible to keep adding more exceptional tests. Hey, perahps even randomize running with and without qorum. But currently we requre >=3 nodes. We could evolve the quorum to use 1 zk node if <3 and use 3 zk nodes for >=3. Then if you kill a solr node, it should all work even if that node also has zk. But I think there were some issues with stopping a `JettySolrRunner` in quorum mode and then restarting it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
