dsmiley commented on code in PR #3774:
URL: https://github.com/apache/solr/pull/3774#discussion_r2437405489
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -86,15 +98,12 @@ private HttpSolrClientBase
createOrGetHttpClientFromBuilder(Builder builder) {
return builder.httpClient;
} else if (builder.internalClientBuilder != null) {
return builder.internalClientBuilder.build();
- } else {
- try {
- Class.forName("org.eclipse.jetty.client.HttpClient");
- } catch (ClassNotFoundException e) {
- log.debug("Using {} as the delegate http client",
HttpJdkSolrClient.class);
- return new HttpJdkSolrClient.Builder().build();
- }
+ } else if (JETTY_CLIENT_AVAILABLE) {
log.debug("Using {} as the delegate http client", Http2SolrClient.class);
return new Http2SolrClient.Builder().build();
+ } else {
+ log.debug("Using {} as the delegate http client", Http2SolrClient.class);
Review Comment:
```suggestion
log.debug("Using {} as the delegate http client",
HttpJdkSolrClient.class);
```
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -380,7 +389,7 @@ public Builder withCollectionCacheTtl(long timeToLive,
TimeUnit unit) {
}
/**
- * Set the internal {@link Http2SolrClient}.
+ * Set the internal client Solr HTTP client.
Review Comment:
That sounds clumsy to me. Maybe just refer to the type --
`HttpSolrClientBase`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
