dsmiley commented on PR #3791: URL: https://github.com/apache/solr/pull/3791#issuecomment-3416925020
I don't believe a unit test would be useful; wouldn't be a good use of time (and long term maintenance). The code change amounts to checking just one more exception. The risk of a screw up is not achieving the goal? I can attest that the benefit is real where I work; we didn't see negative side-effects (and a unit test wouldn't expose such effects if they exist). The underlying issue that brought this about is a macro level thing. Ideally that would be tested, but realistically I don't see that happening unless we find we can induce that event with Docker maybe. Sounds like a lot of work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
