psalagnac commented on code in PR #3773:
URL: https://github.com/apache/solr/pull/3773#discussion_r2435343888
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java:
##########
@@ -359,19 +359,10 @@ public void call(ClusterState clusterState, ZkNodeProps
message, NamedList<Objec
if (async != null) {
String coreAdminAsyncId = async + Math.abs(System.nanoTime());
params.add(ASYNC, coreAdminAsyncId);
- shardRequestTracker.track(nodeName, coreAdminAsyncId);
}
CollectionHandlingUtils.addPropertyParams(message, params);
- ShardRequest sreq = new ShardRequest();
- sreq.nodeName = nodeName;
- params.set("qt", ccc.getAdminPath());
- sreq.purpose = ShardRequest.PURPOSE_PRIVATE;
- sreq.shards = new String[] {baseUrl};
- sreq.actualShards = sreq.shards;
- sreq.params = params;
Review Comment:
I should have commented in the PR. This is all done by calling
`shardRequestTracker.sendShardRequest()` that then calls `ShardHandler`. To me,
this is all internal to shard handler, there was no good reasons to duplicate
this in the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
