janhoy commented on PR #3706: URL: https://github.com/apache/solr/pull/3706#issuecomment-3411046825
> Put differently, if this specific test were to exist as a JUnit/Testcontainers based test, then it really calls into question why we have any Bash/BATS scripts at all -- why would/shouldn't they also be TestContainers based? I like BATS since it is a dead simple way to test the REAL bin/solr experience and our CLI tooling. Probably more so than what our Docker image allows us to. For semi complex tests with lots of checking, timing, need to catch exceptions or what not, I'd choose JUnit/TC. Could we port all BATS tests onto a home grown DSL powered by TestContainers? Sure. Point is we can now choose between three different test suites: Plain JUnit, JUnit with TestContainers or BATS. Choose the tool that seems most fitting for whatever job is at hand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
