bruno-roustant commented on code in PR #126:
URL: https://github.com/apache/solr-sandbox/pull/126#discussion_r2412667893
##########
encryption/src/test/java/org/apache/solr/encryption/EncryptionTestUtil.java:
##########
@@ -234,9 +236,10 @@ public void waitUntilEncryptionIsComplete(String keyId)
throws InterruptedExcept
} catch (Exception e) {
throw new RuntimeException(e);
}
- assertTrue(encryptionStatus.success);
Review Comment:
It is not wrong to throw an assertion error inside a retry, for a condition
that must always be true for all retry attempts. Here the condition must be
true eventually, but it is ok for it to be false during retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
