sigram commented on code in PR #3634:
URL: https://github.com/apache/solr/pull/3634#discussion_r2330567836
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -782,32 +783,31 @@ public QueryResult search(QueryResult qr, QueryCommand
cmd) throws IOException {
return qr;
}
- /*@Override
- TBD . This is overridden to exit the query when limits are reached
- protected void search(List<LeafReaderContext> leaves, Weight weight,
Collector collector)
+ @Override
+ public void search(Query query, Collector collector)
throws IOException {
QueryLimits queryLimits = QueryLimits.getCurrentLimits();
- if (EnvUtils.getPropertyAsBool(EXITABLE_READER_PROPERTY, Boolean.FALSE)
Review Comment:
This condition is most likely obsolete here - if it's true then we're using
the `ExitableDirectoryReader` anyway, regardless whether the query uses limits
or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
