dsmiley commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2353470681
########## solr/core/src/test/org/apache/solr/handler/component/DistributedCombinedQueryComponentTest.java: ########## Review Comment: I concur that in a realistic setting, sharding will yield score variances or ties that could change the final ordering. But why test under that circumstance? It only makes testing harder and for a reader of the tests to understand that the assertions are valid. _We won't have less test coverage by fixing the scores somehow._ I think the vast majority of tests here should operate in this circumstance, which makes them clear to understand / validate. This should save you time (less tests to maintain). If the way RRF tie brakes matters (I doubt it), I could understand adding such a test to ensure we don't introduce a regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
