HoustonPutman commented on code in PR #3643:
URL: https://github.com/apache/solr/pull/3643#discussion_r2352867099
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -423,6 +440,10 @@ public ZkController(
this.overseerCollectionQueue = overseer.getCollectionQueue(zkClient);
this.overseerConfigSetQueue = overseer.getConfigSetQueue(zkClient);
Review Comment:
Would be nice to have a separate refactoring PR. Good restraint haha
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -392,13 +392,19 @@ public ZkController(
// this must happen after zkStateReader has initialized the cluster props
this.baseURL = URLUtil.getBaseUrlForNodeName(this.nodeName,
urlSchemeFromClusterProp);
- // Now that zkStateReader is available, read OVERSEER_ENABLED.
+ checkForExistingEphemeralNode(); // removes our live node if present
Review Comment:
Ahhh very good catch. This will definitely happen, so not just a weird edge
case.
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -392,13 +392,19 @@ public ZkController(
// this must happen after zkStateReader has initialized the cluster props
this.baseURL = URLUtil.getBaseUrlForNodeName(this.nodeName,
urlSchemeFromClusterProp);
- // Now that zkStateReader is available, read OVERSEER_ENABLED.
+ checkForExistingEphemeralNode(); // removes our live node if present
+
+ // Now that zkStateReader is available, read OVERSEER_ENABLED & live nodes.
+ final Optional<SolrVersion> lowestNodeVersion =
zkStateReader.fetchLowestSolrVersion();
+ boolean defaultOverseerEnabled =
Review Comment:
So I have a relatively big question here. So let's say a cloud is rolling
upgraded from 9 to 10.
All nodes after the upgrade will be using the overseer, except for the last
one upgraded to 10 right? That one will be using the distributed cluster state
manager. This seems like an issue, but I have a feeling I'm missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
