liangkaiwen commented on PR #3451: URL: https://github.com/apache/solr/pull/3451#issuecomment-3293873261
The test passes on my local machine, but agreed it is quite slow (18.4s to completion). As for the replica numbers, the number of tlog nodes is equivalent to the max possible of tlog nodes(4) in the test prior to my change with the only change there being removing the random factor. For the pull nodes, the previous value before my change was a globally hard-coded 2, however I bumped this up to 4 so that there is more likelihood the test will catch any issue where atleast 1 pull node gets assigned leader incorrectly. It was noted by a colleague of mine that the test base class here is outdated and might potentially be contributing to the flakiness? If it would be better, I could also reduce the number of replicas to 2 tlog and 2 pull? Let me know if you would like me to proceed with either or both of these ideas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
