ilariapet opened a new pull request, #3644: URL: https://github.com/apache/solr/pull/3644
https://issues.apache.org/jira/browse/SOLR-17814 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Apache Lucene implements an early termination approach for knn queries: [org.apache.lucene.search.PatienceKnnVectorQuery ](https://lucene.apache.org/core/10_2_2/core/org/apache/lucene/search/PatienceKnnVectorQuery.html) This is a version of knn vector query that exits early when HNSW queue saturates over a `saturationThreshold` for more than `patience` times. # Solution A new query type, PatienceKnnVectorQuery, was introduced, exposed through the KnnQParser with three additional parameters: - `earlyTermination` (boolean, default: false) – enables early termination during the search. - `saturationThreshold` (double) – controls the saturation level for early termination. - `patience` (int) – configures the patience factor for the termination strategy. This allows users to decide whether or not to run the vector query with early termination. They can either rely on the default values provided by Lucene or override both of them with custom values. Since the `TextToVectorQParser` extends the same base class, these parameters are also automatically available there, allowing the same early termination functionality without additional changes. # Tests - Test to verify that when no early termination parameters are provided, the default behaviour is applied (i.e. early termination is disabled), and no special logic is triggered. - Test to verify that when early termination is explicitly set to false, no special logic is triggered. - Test to verify that when early termination is explicitly set to true, but no other parameters are provided, the PatienceKnnVectorQuery is executed using the default values for saturationThreshold and patience. - Test to verify that when early termination is explicitly set to true, and both saturationThreshold and patience parameters are provided, the PatienceKnnVectorQuery is executed using the specified custom values (both float and byte query). - Test to verify that when early termination is NOT explicitly passed, but both saturationThreshold and patience parameters are provided, the PatienceKnnVectorQuery is executed using the specified input values. - Test to verify that when an invalid saturationThreshold value is provided in the query (out of range or different from a double), Solr throws a BAD_REQUEST exception with the expected message. - Test to verify that when an invalid patience value is provided in the query (out of range or different from an integer), Solr throws a BAD_REQUEST exception with the expected message. - Test to verify that when only one input parameter is provided in the query, Solr throws a BAD_REQUEST exception with the expected message (both are required). # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
